Project

General

Profile

Actions

Bug #7

open
SB FU

Broken Access Control — Employee can create a performance review for another employee as reviewer

Bug #7: Broken Access Control — Employee can create a performance review for another employee as reviewer

Added by Safia Borsha about 2 months ago. Updated 10 days ago.

Status:
New
Priority:
High
Assignee:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The /add-performance-review endpoint has no role restriction and no check on who is allowed to act as the reviewer. It only requires a valid login, not a specific role such as Manager or HR.

Because of this, a regular Employee can submit a performance review targeting any other employee, freely setting themselves (or anyone else) as the reviewerEmail. The backend trusts whatever reviewer identity is sent in the request body instead of deriving it from the authenticated session, and it never checks whether the caller actually has authority over the employee being reviewed.

In practice, this means any employee could fabricate a performance review — positive or negative — against a colleague, complete with ratings, comments, and an overall score, and it would be stored exactly as if a legitimate manager had submitted it. This undermines the integrity of the entire performance review system, since submitted reviews cannot be trusted to have come from an authorized reviewer.


Files

Screenshot 2026-07-30 103938.png (56.4 KB) Screenshot 2026-07-30 103938.png Safia Borsha, 07/30/2026 10:39 AM
Screenshot 2026-07-30 103938.png

MA Updated by Miaki Admin 10 days ago Actions #1

  • Project changed from HRMS Portal to Sprint 3

MA Updated by Miaki Admin 10 days ago Actions #2

  • Project changed from Sprint 3 to Sprint 1
Actions

Also available in: PDF Atom